Reconnect #187
Merged
Reconnect #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
May 31, 2014 07:28
Freelist implements LIFO queue. This means that when the buffers are added from the vm, they'll be used in reverse order (remove pops the last one). This patch uses a different algorithm to add buffers so they can be popped in the ascending order. This is done for both Rx and Tx. Signed-off-by: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>
In order to reconnect we need to restore txavail and rxavail. We restore them from the used.idx of each vring. Signed-off-by: Nikolay Nikolaev <n.nikolaev@virtualopensystems.com>
|
Thanks! This should be really practical, even given the caveats. It's quite a luxury to be able to restart the snabb process at any time e.g. when doing integration testing with another box and deploying a series of small code tweaks to make it happy. |
lukego
added a commit
that referenced
this pull request
Jun 4, 2014
vhost-user reconnect support (limited)
mwiget
pushed a commit
to mwiget/snabb
that referenced
this pull request
Jan 3, 2016
Auto compile address map
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch set implements a simple "reconnect" feature on the snabbswitch side only.
It does 2 things:
This works under no or light load (ping).
Under heavy load one needs to restart the interface in the virtual machine, for example:
ifconfig eth0 down && ifconfig eth0 up
NOTE: This feature is not tested enough for production quality. It relies on buffers being used in a particular order.