some speed-ups (based on bench/basic1) #201
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
June 6, 2014 15:25
|
Looks promising! How much is the total speed up? Do all these changes measurably contribute to the speed up, or are there some we can safely skip? Skipping the zero-fill on freed packets is a bit too aggressive. For example, the length field won't be reset. You could skip this change and let me do something here: there is some cruft in packet.h (unused fields) that I need to remove at the same time. Travis-CI build failed. Can you see why? (Does "make test" work for you?) Can you please rebase this to master so that there is no merge commit in the pull request? |
|
See also snabb-devel thread on whether we could automate the process of measuring the performance impact of new changes. |
|
Superseded by #203. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.