-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for Issue #40 #41
Conversation
This also uncomments the write RXDCTL by including commit 1286653. Intended? |
Well, that was the fix for issue #1 which was merged in the master branch. If you look at the other commits, those were merged from the master branch. The only change from the current master is the line 42 in intel.lua (as shown in 'Files Changed' tab) Let me know if it doesn't work - If you want, I can send a new pull request (without all the commit history) |
Fun :-). I'm not such an expert with Git so I am clicking and playing around a bit to try and understand how the master history looks after taking in such a pull request. |
OK I'm working on understanding the git/github workflow. The pull request contains: If I
Is this as it should be or does it make sense to eliminate the merge commit somehow? (would you do that or would I?) |
On 01/16/2013 11:58 PM, Luke Gorrie wrote:
I think polluting the master history with unrelated merge commits is not |
Extract the lookup queue code from BindingTable into its own BTLookupQueue object, and instantiate it outside of BindingTable
Change the way variable 'bound' is calculated (details in Issue #40)