flatten child arrays to allow nesting #10
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems that snabbdom does not allow nested arrays within the children array. This means you can't write code like, e.g:
because this essentially translates to
Note that the second item of the ul's children array is itself an array. Snabbdom doesn't like this and fails silently, rendering the string 'undefined' in place of the array.
Also note that
works perfectly well because if there is only one child and it is an array, snabbdom-jsx uses it as the children array.
Perhaps this is the intended behaviour. My use case is probably somewhat rare and maybe it's fine to fall back to
h
to handle such cases. Anyway I figured I'd offer this as a PR because it's not much code and shouldn't touch perf outside of extreme cases.