fix: generate valid javascript modules in build. fixes #963.

[mreinstein]

No description provided.

[mreinstein]

#963

[jvanbruegge]

I would strongly prefer something like this instead of basically importing non-existent javascript files

[mreinstein]

tsc doesn't seem to have any issues with resolving .js. npm run build and npm run unit work without issue, even with this change:

[mreinstein]

I would strongly prefer something like

@jvanbruegge done.

[kuraga]

@mreinstein , thanks very much!

@mreinstein , @jvanbruegge , some questions, please... As the result:

1. Are our output files scripts (.js) or modules (.mjs)?
   (Update: oh, .js files and "type": "module" in package.json)
2. Can we import them as ECMAScript Modules?
3. Can we require() them as CommonJS files?
4. Can we import them as TypeScript Modules (in a TypeScript project)?

Thanks!

P.S. https://2ality.com/ has articles about these (the 2022 state).

[mreinstein]

1. our output files are es modules, with the .js file extension.
2. yes, you can import them in a browser as a URL, or in node, provided you have set "type": "module" in your package.json and are using node >= v12.18.x
3. not directly, but you can use build tooling to handle that if you want it. I don't use legacy cjs anymore, and this project hasn't for a long time either.
4. I can't speak to

[kuraga]

@mreinstein , thanks! Now I see (and yes, this PR doesn't change globally introduced by 09f2d1c and 7af7e3f).

But yeah, it's nice to add an instruction for TypeScript projects...

[iambumblehead]

In the current master branch, npm run build produces a jsx.js file with a bad import.

$ grep \\.\/h build/jsx.js
import { h } from "./h"; // should be "./h.js"

I encountered the issue in another PR and patched the file with sed https://github.com/snabbdom/snabbdom/pull/1084/files#diff-2d40d3ee7ec7a92500d7f2dbb4ab60b274c089a6062d7c5ac0cf9fdc63eddfe1R14

---

#439

Can we pause on this for a minute? We've already inundated the maintainers with a lot of material today. I'd like to get other existing PRs/issues resolved before we expand out into more discussions.

#957 (comment)

Possibly, but I'm waiting for feedback from Jan. There's already a lot of stuff flying around today. I don't want to jam more activity in until he's had a chance to catch up.

These things don't feel good: "unpausing/unrelenting", "inundating", "preemptively expanding" and "jamming"

Please allow me to comment without casting such things and allow others to represent their own thoughts to the rest.

[mreinstein]

You pinged me and specifically asked for suggestions:

mreinstein kuraga jvanbruegge feel free to give any suggestions or ideas

My suggestion is to chill for a second and give the other maintainers a chance to catch up before creating more material to parse. I never said you are not allowed to comment. If you don't want suggestions or ideas, don't ask people for them.