Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: detect window.requestAnimationFrame function before calling #1082

Merged
merged 1 commit into from
Jan 16, 2024
Merged

fix: detect window.requestAnimationFrame function before calling #1082

merged 1 commit into from
Jan 16, 2024

Conversation

iambumblehead
Copy link
Contributor

essentially, this is the same as #885

@iambumblehead iambumblehead marked this pull request as ready for review November 29, 2023 16:28
src/modules/style.ts Outdated Show resolved Hide resolved
Copy link
Contributor

@mreinstein mreinstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mreinstein
Copy link
Contributor

@iambumblehead any idea why the ci check is no longer passing? It says Waiting for status to be reported. I saw that some commits which changed the ci in some ways got merged today. Related to those?

@iambumblehead
Copy link
Contributor Author

iambumblehead commented Nov 29, 2023

@mreinstein I think there is a project-wide setting to require the "ci" job to pass and the "ci" job is not longer there because it was renamed "test" https://docs.github.com/en/actions/using-workflows/required-workflows

@mreinstein
Copy link
Contributor

Is this the commit that broke it? 856f26a If so can we put it back? Having the ci system broken is very bad.

@iambumblehead
Copy link
Contributor Author

@mreinstein I'm confident the workflow issues will be resolved :)

Let's see what @jvanbruegge thinks. Reverting the changes is one option and another option is to move forward with the name "test" for the test pipeline.

https://docs.github.com/en/actions/using-workflows/required-workflows

Note: GitHub is deprecating support for required workflows for GitHub Actions.

@paldepind
Copy link
Member

LGTM! Thanks for the PR.

@paldepind paldepind merged commit ba080f5 into snabbdom:master Jan 16, 2024
2 checks passed
@iambumblehead iambumblehead deleted the detect-requestanimationframe-before-using branch January 16, 2024 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants