the styleModule has problems handling style updates with attribute values of 0

[chuifengji]

the styleModule has problems handling style updates with attribute values of 0

for (name in oldStyle) {
    if (!style[name]) { // here's the mistake
      if (name[0] === "-" && name[1] === "-") {
        (elm as any).style.removeProperty(name);
      } else {
        (elm as any).style[name] = "";
      }
    }
  }

The above code should be changed to：

for (name in oldStyle) {
    if (!(name in style)) { // how to fix it
      if (name[0] === "-" && name[1] === "-") {
        (elm as any).style.removeProperty(name);
      } else {
        (elm as any).style[name] = "";
      }
    }
  }

[chuifengji]

I run into this problem when the flex-shrink value is 0

[paldepind]

Thank you for reporting this @chuifengji. I'll take a look at this.

In the meantime, I think you should be able to work around the problem by using "0" instead of just 0 as your flex-shrink value.

[paldepind]

Can you describe exactly what problem you are experiencing? I can see that the line you highlight is not ideal, but it's not clear how this results in a bug (except for the property being set to "" and then re-set correctly when the new properties are handled).

[paldepind]

@chuifengji Please see #1094 which should fix your problem.

[chuifengji]

thanks!