Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: .node-version, .nvmrc and nodenv files #423

Merged
merged 1 commit into from May 18, 2019

Conversation

mightyiam
Copy link
Contributor

Closes #422

@sne11ius
Copy link

sne11ius commented May 15, 2019

The fact that this PR lingers for 2 months without any comment makes me question the overall quality of this project to be honest. Seems not to be too actively maintained.
Apart from that: I know I'm not entitled to anything ;)

@paldepind
Copy link
Member

Thanks for the PR @mightyiam. I'm wondering how you arrived at v6.10.1 as the NodeJS version?

@sne11ius It's probably fair to say that Snabbdom is not too actively maintained 😉. But it's not unmaintained either and the project has been used by many people for many years. It has been battle tested and is stable. If you have doubts about the "overall quality of the project" that are related to the code itself, let me know. And btw, writing comments, like you did above, is a fine way to increase the chance that I or others will take a look at issues/PRs. So feel free to keep doing that 😄

@paldepind paldepind merged commit e4efc1d into snabbdom:master May 18, 2019
@mightyiam mightyiam deleted the node-vesion-file branch May 19, 2019 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Declare development version of Node.js
3 participants