Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to deactivate coupons on the coupons details page (APPS-781) #184

Merged
merged 7 commits into from
Jul 2, 2024
Merged

Add option to deactivate coupons on the coupons details page (APPS-781) #184

merged 7 commits into from
Jul 2, 2024

Conversation

Fabtron
Copy link
Collaborator

@Fabtron Fabtron commented Jun 11, 2024 •
edited
Loading

What's new?

The user is now able to deactivate his applied coupons via the details page of the selected coupon.

How to test?

Include this branch in any application using coupons.

  • Add a coupon and check wether it is applied top the shopping cart (switch to the scanner)
  • Remove the coupon and check if the cart is updated accordingly
  • Add the coupon again and remove inside of the shopping cart (vie swipe delete). Check if the details page updates accordingly (coupon should be on inactive)

Apps-781

Definition of Done

  • Changelog gepflegt

  • Dokumentation gepflegt

  • Alle Anforderung des Issues sind erfüllt

  • Selbst greviewed (aka Self-Reviews (eng))

  • Review mit Product Owner (Release-Variante o. Minified Build)

  • App Tests

    • Minified getestet? (aka. Release Build)
    • Environements beachtet (Production/Staging)
    • Unterstützte Sprachen sind getestet
    • Light-/Dark-Mode getestet
    • Edge-Cases getestet
    • Android API Levels wurden berücksichtigt (minSdk?)

  • Testing

    • Tests geschrieben (aka Unit-Tests, Integration-Tests)
    • Tests lokal laufen gelassen

@Fabtron Fabtron marked this pull request as ready for review June 11, 2024 08:52
@Fabtron Fabtron requested a review from cmaier June 11, 2024 08:53
@Fabtron Fabtron changed the base branch from main to feature-shopping-cart July 2, 2024 09:14
@Fabtron
Merge branch 'refs/heads/feature-shopping-cart' into apps-781-deactiv…
02b965c 
…ate-coupons-option

# Conflicts:
#	core/src/main/java/io/snabble/sdk/ShoppingCart.java
@Fabtron
merge feature shopping cart
cf1d20c
@Fabtron Fabtron merged commit 3b3316d into feature-shopping-cart Jul 2, 2024
1 check passed
@Fabtron Fabtron deleted the apps-781-deactivate-coupons-option branch July 2, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmaier cmaier Awaiting requested review from cmaier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@Fabtron