Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RespawnBsp.save_as dumps .bsp_lump copies in working directory #143

Closed
snake-biscuits opened this issue Aug 22, 2023 · 1 comment
Closed

RespawnBsp.save_as dumps .bsp_lump copies in working directory #143

snake-biscuits opened this issue Aug 22, 2023 · 1 comment
Assignees
@snake-biscuits
Labels
bug Something isn't working Test Map Adding a map to ship with bsp_tool for tests Titanfall Engine Applies to all Titanfall Engine branch scripts
Milestone
v0.6.0

Comments

@snake-biscuits
Copy link
Owner

.bsp_lump still turns up in the directory we're saving to, but for some reason we're polluting the working dir
Automated testing doesn't cover .bsp_lump, which is why this wasn't caught sooner
@snake-biscuits snake-biscuits added Test Map Adding a map to ship with bsp_tool for tests need test We need to write a test for regression testing Titanfall Engine Applies to all Titanfall Engine branch scripts labels Aug 22, 2023
@snake-biscuits snake-biscuits added this to the v0.6.0 milestone Aug 22, 2023
@snake-biscuits snake-biscuits self-assigned this Aug 22, 2023
@snake-biscuits snake-biscuits added the bug Something isn't working label Aug 22, 2023
snake-biscuits added a commit that referenced this issue Aug 22, 2023
@snake-biscuits
(#143) fixed RespawnBsp.save_as()
f20fe77
@snake-biscuits
Copy link
Owner Author

Should have correct behaviour for Apex Season 10+ now
(header only .bsp & all lump data in external lumps)
Haven't tested that yet though

Also idk if it's possible to try that format in R5R anyway

@snake-biscuits snake-biscuits mentioned this issue Aug 24, 2023
Open
14 tasks
@snake-biscuits snake-biscuits removed the need test We need to write a test for regression testing label Aug 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snake-biscuits snake-biscuits

Labels
bug Something isn't working Test Map Adding a map to ship with bsp_tool for tests Titanfall Engine Applies to all Titanfall Engine branch scripts
Projects
bsp_tool Core Functionality
Status: Done
Milestone
v0.6.0
Development

No branches or pull requests
1 participant
@snake-biscuits