fix: Updated the get-transcript-info.R file and its dependencies #73
+98
−57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added heatmap and QC plot to report.html
…s and updated codes
…scripts for 3prime quantification
Co-authored-by: Johannes Köster <johannes.koester@tu-dortmund.de>
Co-authored-by: Johannes Köster <johannes.koester@tu-dortmund.de>
Co-authored-by: Johannes Köster <johannes.koester@tu-dortmund.de>
Co-authored-by: Johannes Köster <johannes.koester@tu-dortmund.de>
johanneskoester
requested changes
Jun 2, 2023
johanneskoester
requested changes
Jun 12, 2023
johanneskoester
requested changes
Jun 14, 2023
Comment on lines
124
to
133
| if (three_prime_activated && has_mane_select) { | ||
| t2g <- t2g %>% | ||
| filter(!str_detect(chromosome_name, "patch|PATCH")) %>% | ||
| filter(str_detect(transcript_mane_select, "")) | ||
| }else if (three_prime_activated && !has_mane_select) { | ||
| stop( | ||
| str_c( | ||
| "needed mane_selected column in biomart if three prime mode is activated" | ||
| )) | ||
| } |
There was a problem hiding this comment.
This can be written in a much simpler way. First check for only three_prime_activated, and in that if handle both cases about has_mane_select or not.
There was a problem hiding this comment.
Noted. Thank you pointing it. Updated the code.
johanneskoester
approved these changes
Jun 14, 2023
johanneskoester
pushed a commit
that referenced
this pull request
Jun 14, 2023
🤖 I have created a release *beep* *boop* --- ## [2.5.1](v2.5.0...v2.5.1) (2023-06-14) ### Bug Fixes * Updated the get-transcript-info.R file and its dependencies ([#73](#73)) ([e44d424](e44d424)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.