-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactoring structure to keep settings in user home #22
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
snakeface init created the ~/.snakeface dir with the expected resources, specifically settings.yml. But, when I edit the domain_host and domain_port, they do not get used when running snakeface again :-/ i can still set --port on the command line, but not change the IP |
Signed-off-by: vsoch <vsoch@users.noreply.github.com>
Should be all set d27d59f. |
hi @vsoch -- Long time ! Sorry, for such a lag. But yes, it works fine now with init and editing the user home settings.yaml :-) I did run via python 3.9, and had a problem with the pgsql binary that I could only fix with: mamba install -n SNKF2 psycopg2-binary I also attempted to correct 2 dead links in the readme, but did not have permissions- you'll see them. Thanks- I should have a little time to play around some more soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These worked for me as stated, however the seriously gnarly django hack I employed to enable registration of manually started workflows outside snkFce ceased to work- but that was nothing to expose the world to really : andI should determine how to do that correctly. I'm giving a talk on the superpowers of snakemakemakethis coming week, and hope I find the time to have a functioning re-build to tease.
So - you are ready to merge this? Or you'd like something else fixed? |
This is a quick refactor to address some problems discussed in #21. I think the issue this user is facing is that the install was messy - we shouldn't require the user to clone and install locally, it should just work with pip install snakeface, and then we write whatever we need to the user home. This is optimized for the notebook use case, which (since we don't have other plugins for auth yet) I think is safe to focus on for now. This means that:
I think we could improve things by using ruamel.yaml (which preserves comments) but this should be good for a first. shot.
Signed-off-by: vsoch vsoch@users.noreply.github.com