Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing R dependencies #257

Merged
merged 4 commits into from
Nov 17, 2020
Merged

Conversation

fgvieira
Copy link
Collaborator

@fgvieira fgvieira commented Nov 9, 2020

Added missing R dependencies.

Copy link
Contributor

@dlaehnemann dlaehnemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure any of this should be necessary. What was the root problem that motivated these additions?

bio/mapdamage2/environment.yaml Outdated Show resolved Hide resolved
bio/mapdamage2/environment.yaml Outdated Show resolved Hide resolved
@dlaehnemann
Copy link
Contributor

I just tried the following and it worked for me, including stating that it is Performing Bayesian estimates. So maybe this is some artefact of a conda setup somewhere? Or some other weird side effects?

mamba create -n mapdamage2 mapdamage2=2.2.1
conda activate mapdamage2
mapDamage --input test.sorted.bam --reference genome.fasta --folder test --rescale-out test.rescaled.bam

@fgvieira
Copy link
Collaborator Author

ok, so it seems it was because of a conflict between R packages.
It seems that, even though R and R packages are installed through conda, the R_LIBS variables takes precedence if it is defined.

Either way, I've removed the patch version and pinned it to minor version only.
best

@dlaehnemann
Copy link
Contributor

Ah, yeah. Thanks for the patience and keeping on digging on your end. This does seem messy, judging for the (stalling) attempts to fix this in conda:
conda-forge/r-base-feedstock#65

Copy link
Contributor

@dlaehnemann dlaehnemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This minimal change obivously makes sense, so I'll merge it!

@dlaehnemann dlaehnemann merged commit 85dbed2 into snakemake:master Nov 17, 2020
@mbargull
Copy link

It seems that, even though R and R packages are installed through conda, the R_LIBS variables takes precedence if it is defined.

Ah, the PYTHONPATH of the R world. Yes, that makes sense; I hadn't thought about that!
@fgvieira, thank you very much for the followup -- that's quite helpful for debugging future issues of other users!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants