Add Ctrl/Cmd-Q keyboard shortcut to quit #24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will need to define a proxy for a function on WorldMorph in order to support Ctrl/Cmd-Q keyboard shortcuts. This is also cleaner code anyhow (it uses function scoping instead of the global namespace and is arguably easier to understand). This diff is pretty hard to read because of indentation changes. You can get a cleaner diff by specifying -w in git-diff (or ?w=1 in the URL on GitHub).
Fairly straightforward - we detect if a quit combo was pressed, then tell the window to close if one was.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #15 by causing the browser window to close when the user presses Ctrl-Q (or Cmd-Q on a Mac). This does mesh nicely with #23.
The diff is pretty tough to read as it is, so I recommend reading the two commits one at a time, or at least specifying
?w=1in the "files" URL.