Change SameSite to Lax during Development in app.lua #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! This is good to know it fixes the development issues. Not sure why I haven't seen them personally. However, I think we need |
ochan1
changed the title
|
Changes made as described Dedicated "if" statement for Development to set the proper setting for secure and sameSite, default to production values |
|
Does this lgtty, @cycomachead? If so let's go ahead and pull it. |
|
@cycomachead ping? :) |
|
Whoops, sorry I missed this. Looks good, thanks Oscar!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #277
Confirmed that setting the SameCookie attribute to "Lax" fixes the issue for development
"None" works in the deployed website (for some reason)
Tested on Chrome and Opera (both Chromium browsers)