refact: reworks test framework integration #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
pftg
commented
Jul 16, 2024
•
pftg
commented
- Mock Capybara's approach to the setup project.
- Compressing the namespace path and dropping extra 2 nested modules
- Reduced dependency on the dynamic value constant
- Reduced minitest dependency if you are using RSpec
- Upgraded minitest with fixed version
|
@UweKubosch please check |
|
@donv fixed the issue, for now decided to have separate screenshots per driver to prevent inconsistency in image sizes. So far all tests are green, expect some jruby had some not related to our code issues and raises timeouts |
* build: increase time limits per jruby * refact: move to separate action to setup ruby * build: setup jruby config to make it pass
|
HUGE PR! |
donv
approved these changes
Jul 17, 2024
* removed redundant names per steps
pftg
force-pushed
the
feat-extract-test-framework-integration-new
branch
from
1ef0d0f
to
89967ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.