-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
move createLi into a setTimeout on init to prevent interference with …
- Loading branch information
Showing
1 changed file
with
35 additions
and
22 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50b2327
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi,
This change broke some code we had, in case you operate on the select picker inmediately after creation, like in:
It doesn't work anymore, fails at bootstrap-select.js:2590, at changeAll, because current.elements doesn't exist. (first assignment of current to main happens at createLi.
As I've seen there are some other methods that use current.elements and we have a large code base, it would be acceptable to include some option to init the component inmediately? I'm interested in updating because of virtualScroll, but I'm afraid of subtle hidden bugs like the one we found.
50b2327
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaime-blazquez Please open a new bug report following our contribution guidelines and I'll investigate further. Thanks!
50b2327
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jaime-blazquez Please 👍 and follow #2337.