Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Live search got stuck, on some chars #1310

Closed
authanram opened this issue Feb 25, 2016 · 2 comments
Closed

Live search got stuck, on some chars #1310

authanram opened this issue Feb 25, 2016 · 2 comments

Comments

@authanram
Copy link

Hi there,

don't know if the issue was already posted here before. I've read a lot of issues here, but can't find it.

Example-URL: https://silviomoreto.github.io/bootstrap-select/examples/
Tested in Chrome 48 and Firefox 44 (both on Mac El Cpt.)

How to reproduce:

  1. go the url above
  2. scroll down to the section "Live search"
  3. click the select (at the section "Live search"), just to focus it
  4. tab (with the keyboard) to the next select element at the section "Key words"
  5. hit the char "h" on your keyboard

Now the live search field is not focused and something is completely wrong with the select element.

The funny thing is, this will happen only with some chars. So please use the char "h" to reproduce that. If you type "a" everything is fine.

The biggest shit with that is, if the user runs into this issue and hits "backspace" on the keyboard, the browser will navigate back and all entered form data will be lost. hmpf

I've discovered that today because of a tracking analysis on my online service. I've recognized that a lot of users start filling a form, navigate back to the page before, navigate forward again to the form and send it afterwards. That means, a lot users called the same url twice or more. Regarding that i've had a closer look to that form and found that issue.

So, for me/my service, this is a tremendous issue at the moment, because the conversion is decreasing because of that. ^^

@authanram authanram changed the title Live search stuck for unclear reason Live search stuck for unclear reason, on some chars Feb 25, 2016
@authanram authanram changed the title Live search stuck for unclear reason, on some chars Live search got stuck, on some chars Feb 25, 2016
@authanram
Copy link
Author

Solution: return; right after that.$searchbox.focus(); at line 1480. We're in (!isActive ...) { ... }. So no further processing is needed after focusing the the search field.

@caseyjhol
Copy link
Member

Good catch - thanks for posting the solution.

avantika-gupta-jtg pushed a commit to JoshLabs/bootstrap-select that referenced this issue May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants