Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't render checkMark (tickIcon) if showTick is false or the select is not multiple #1425

Closed
anthonygreco opened this issue Jun 22, 2016 · 1 comment
Closed

Don't render checkMark (tickIcon) if showTick is false or the select is not multiple #1425

anthonygreco opened this issue Jun 22, 2016 · 1 comment

Comments

@anthonygreco
Copy link

anthonygreco commented Jun 22, 2016 •
edited

When setting showTick: true, the <span class="glyphicon glyphicon-ok checkmark"></span> markup is still rendered. Another ternary conditional in the generateA method resolves this.

PR: #1426
@anthonygreco anthonygreco mentioned this issue Jun 22, 2016
Closed
@caseyjhol caseyjhol added this to the v1.14.0 milestone Aug 31, 2018
caseyjhol added a commit that referenced this issue Oct 15, 2018
@caseyjhol
Don't render checkMark (tickIcon) if showTick is false or the select …
b8fadf6 
…is not multiple (#1425, #1426). Mild performance boost.
@caseyjhol caseyjhol changed the title Remove additional markup per config Don't render checkMark (tickIcon) if showTick is false or the select is not multiple Oct 15, 2018
@caseyjhol caseyjhol removed this from the v1.14.0 milestone Oct 15, 2018
@caseyjhol
Copy link
Member

Released in v1.13.3!

@klaymen klaymen mentioned this issue Mar 21, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@anthonygreco @caseyjhol