Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selectAllText & deselectAllText missing from most i18n files #1529

Closed
vlsg opened this issue Oct 4, 2016 · 3 comments
Closed

selectAllText & deselectAllText missing from most i18n files #1529

vlsg opened this issue Oct 4, 2016 · 3 comments

Comments

@vlsg
Copy link

vlsg commented Oct 4, 2016

I am successfully including i18n files when the user's language is not set to English, however there are some text options which are not specified in about half of these files, primarily the selectAllText, deselectAllText and doneButtonText. For example, both the spanish and italian js files do not specify the translations for these texts. Unfortunately I do not speak those languages so I do not know the translations in order to contribute. Could these files be updated to include translations for all text properties? Our end users would be very grateful!

Thank you.

@caseyjhol
Copy link
Member

caseyjhol commented Oct 7, 2016

Looks like the following files don't have the translation:

  • defaults-cs_CZ.js
  • defaults-eu.js
  • defaults-nl_NL.js
  • defaults-pl_PL.js
  • defaults-pt_BR.js
  • defaults-pt_PT.js
  • defaults-ro_RO.js
  • defaults-ru_RU.js
  • defaults-ua_UA.js
  • defaults-zh_CN.js
  • defaults-es_CL.js
  • defaults-it_IT.js

@vsc55
Copy link

vsc55 commented Oct 12, 2016

The "defaults-es_CL.js" file can also be used to es_ES "defaults-es_ES.js" as the translation is the same.

@vsc55
Copy link

vsc55 commented Oct 12, 2016

Attachment translation with the new translated var.
Language: "es_ES"

defaults-es_ES.js.txt

caseyjhol added a commit that referenced this issue Nov 16, 2016
select text addition and logic to countselected (#1529)
caseyjhol added a commit that referenced this issue Dec 9, 2016
Update Russian translation (defaults-ru_RU.js) (#1529)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants