Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Safari 11.0.3 Bug (Always 'bold' Text (for noneSelectedText)) #1913

Closed
mikeploeger opened this issue Feb 13, 2018 · 3 comments
Closed

Fix: Safari 11.0.3 Bug (Always 'bold' Text (for noneSelectedText)) #1913

mikeploeger opened this issue Feb 13, 2018 · 3 comments

Comments

@mikeploeger
Copy link

mikeploeger commented Feb 13, 2018 •
edited

Fix on line 526 in bootstrap-select.js:

Old:
'<span class="filter-option pull-left"></span>&nbsp;' +

New:
'<span class="filter-option pull-left"></span>' +
Due to this, the 'noneSelectedText' was bold in Safari.
After the fix the text looked normal like expected.

Cant reproduce the bug in Firefox, seems to be a Safari issue. (macOS)

But anyway, the &nbsp; in this line is really unnecessary and should be removed.
@mikeploeger mikeploeger changed the title Bug + Fix for Safari 11.0.3 Bug (Bold Text of noneSelectedText) Bug + Fix for Safari 11.0.3 Bug (Always bold like Text (for noneSelectedText)) Feb 13, 2018
@caseyjhol
Copy link
Member

What version of bootstrap-select are you using? Is this bug occurring in v1.13.0-beta? https://github.com/snapappointments/bootstrap-select/releases/tag/v1.13.0-beta

caseyjhol added a commit to snapappointments/bootstrap-select-temp that referenced this issue Feb 21, 2018
@caseyjhol
remove &nbsp (snapappointments/bootstrap-select#1913)
1f66733
@mikeploeger
Copy link
Author

mikeploeger commented Feb 21, 2018 •
edited

I'm using v1.12.4.
Thank you for taking your time to commit the fix to the repo.

@caseyjhol
Copy link
Member

Released in v1.13.0!

@mikeploeger mikeploeger changed the title Bug + Fix for Safari 11.0.3 Bug (Always bold like Text (for noneSelectedText)) Fix: Safari 11.0.3 Bug (Always 'bold' Text (for noneSelectedText)) Oct 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@caseyjhol @mikeploeger