Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting option by typing is not working correctly in 1.13.6 #2226

Closed
Jogai opened this issue Mar 12, 2019 · 4 comments
Closed

Selecting option by typing is not working correctly in 1.13.6 #2226

Jogai opened this issue Mar 12, 2019 · 4 comments

Comments

@Jogai
Copy link

Jogai commented Mar 12, 2019

Test Case: https://codepen.io/jogai/pen/LazgKb

  • Open the browser console
  • Open the first select
  • Start typing "November" (in this setup its actually enough to type just 1 alphabetic character)

Issue:

November is so far down the list that its not visible, so users cant see what they're doing. (and console is throwing an error)

Edit: seems to be a regression from 1.13.5 and is a single issue

@Jogai Jogai changed the title 2 issues on selecting option by typing Selecting option by typing is not working correctly in 1.13.6 Mar 12, 2019
@caseyjhol
Copy link
Member

Looks like element.focus() accidentally got swapped with element.trigger('focus') when removing the jQuery shorthand (even though the element is native).

@Jogai
Copy link
Author

Jogai commented Mar 12, 2019

Thanks, good to see the 'next release' label on this one.

@caseyjhol
Copy link
Member

Released in v1.13.7!

@Jogai
Copy link
Author

Jogai commented Mar 18, 2019

It might have something to do with how I instantiate this, but if the select is accessed with a tab typing still doesnt scroll the right option into the view.

Also the window padding is not respected on select with custom content (or should I make another issue for that?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants