Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Livesearch Performance #1516

Merged
merged 1 commit into from Oct 7, 2016

Conversation

andrews05
Copy link

@andrews05 andrews05 commented Sep 18, 2016

When working with large lists, livesearch can start to show a little lag when typing. I've reworked the input listener to improve the performance. The gains are primarily from reducing the number of queries that are made. In my test case, this code runs at least 10x faster than before.
This also fixes a couple of edge cases where a divider wouldn't show/hide correctly.

@andrews05
Copy link
Author

Minified files removed as per updated guidelines.
Keen to hear any comments on this as it makes a real difference to how responsive it feels in some of the menus I'm using.

@poziomek
Copy link

poziomek commented Oct 6, 2016

  1. List with 3600 entries, both: values and displayed text are strings. Changes from this commit help us to reduce search latency (during typing). Great work.
  2. I've took source codes directly from commit (bootstrap-select.js file from commit window) and it seems that works.

@caseyjhol
Copy link
Member

Will try to get this implemented ASAP.

@caseyjhol caseyjhol merged commit 514b4b6 into snapappointments:master Oct 7, 2016
@poziomek
Copy link

poziomek commented Oct 7, 2016

Thank you!

@caseyjhol
Copy link
Member

This also addresses #1275.

@andrews05
Copy link
Author

Thanks for merging this! Glad to hear I'm not the only one working with stupidly large lists.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants