Fix <li> tags inside <option> being treated as options #1674
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The findLis() function used a too broad selector which included <li>
tags inside <option>. For example for this <select>:
<select>
<option><ul><li>demo</li></option>
</select>
findLis() would find two <li>s in generated code: one for <option> and one
inside it.
One side effect of this bug is that check mark is shown properly only for
the first option. For following options the `selected` class is assigned
to incorrect <li>s.
|
Available in v1.13.0-alpha. |
fracz
pushed a commit
to iisg/redo
that referenced
this pull request
Mar 24, 2019
Checkmarks don't appear properly in multi-select resource kind pickers because snapappointments/bootstrap-select#1674 Change-Id: I6675f1d95ccb4ae0ca5c8f8aa573566d59753487
fracz
pushed a commit
to iisg/redo
that referenced
this pull request
Nov 10, 2019
Checkmarks don't appear properly in multi-select resource kind pickers because snapappointments/bootstrap-select#1674 Change-Id: I6675f1d95ccb4ae0ca5c8f8aa573566d59753487
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
findLis()function used a too broad selector which included<li>tags inside<option>. For example for this<select>:findLis()would find two<li>s in generated code: one for<option>and one inside it.One side effect of this bug is that check mark is shown properly only for the first option. For following options the
selectedclass is assigned to incorrect<li>.