Improve init performance #1687
Closed
Improve init performance #1687
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
One thing I wasn't quite sure about: The setDisabled function sets href to '#' if disabled and removes href if enabled. Is this correct or should it be the other way around? |
|
@andrews05 That's a good question. My guess is it was supposed to be the other way around (added in b689ac6). I don't really see a purpose for it, so I'll remove enabling/disabling href in the next release. |
|
Available in v1.13.0-alpha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves initialisation performance in two ways:
$this.index() === 0to!this.previousElementSibling. This makes a huge difference for large optgroups.I found this improved speed by a minimum of 2x with no optgroups, but over 10x for an optgroup with 2k options.