Fix ajax search and maxOptions. Add initial Cypress tests

[caseyjhol]

• fixes Ajax search get multiple calls #2659
• fixes Ajax search not works #2671
• fixes maxOptions display bug #2593
• add some basic Cypress tests/workflow
• support passing in a boolean more argument as an additional argument to the callback function
• remove source.load method in favor of simply using source.data. page is now passed into source.data as the 2nd argument (just like source.search). If you want static data on init (and don't want to call your AJAX function), you can just check page === 0).

Demo: https://plnkr.co/edit/1j2mceV5ewKIxp9n

[caseyjhol]

@NicolasCARPi This is still a WIP. I'll send it your way to review once I'm done.

[caseyjhol]

removing this duplicate block

[caseyjhol]

@NicolasCARPi I'm still working on fixes for #2671, but there's no reason those should hold up this fix. Let me know your thoughts on dropping the source.load method.

[NicolasCARPi]

I think it would be best to have a test case in the tests folder, with a fake ajax call (just a function returning stuff), so we can actually assess if the fix works and have different test case (you said the bug wasn't found before because it was only triggered in certain conditions).

We don't have automated tests (yet), but I believe it's important to add test cases when possible.

[caseyjhol]

@NicolasCARPi Have you made any progress on implementing Cypress? I also have Cypress experience and might try to tackle some of the initial groundwork if you haven't already.

[NicolasCARPi]

Nope, I didn't, so feel free to lay the groundwork ;)

[NicolasCARPi]

I think it's great to finally have some end to end testing! This should be merged and a new beta version must be released ASAP :)

[caseyjhol]

@NicolasCARPi Yes it's about time. I'm excited to add more. Going to make it so much easier to add new features and fix bugs. Just need to update the changelog and I think we can prep for a release. I'd like to also look into it to see if there's a way to automatically create a nuget release at the same time as well.

[NicolasCARPi]

create a nuget release

sure, see: https://github.com/marketplace/actions/publish-nuget

Keep in mind that github actions have issues right now ;) https://www.githubstatus.com/