ci: update to new-style Snapcraft credentials in workflow

snapcore · Oct 27, 2023 · 9060b3f · 9060b3f
1 parent ae0adca
commit 9060b3f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml
@@ -10,7 +10,7 @@ jobs:
   unit: # make sure build/ci work properly
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - run: |
         npm install
         npm run all
@@ -19,13 +19,14 @@ jobs:
     if: github.event_name != 'pull_request'
     runs-on: ubuntu-latest
     steps:
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - uses: snapcore/action-build@v1
       id: build
       with:
         path: './sample-project'
     - uses: ./
       with:
-        store_login: ${{ secrets.STORE_LOGIN }}
         snap: ${{ steps.build.outputs.snap }}
         release: edge
+      env:
+        SNAPCRAFT_STORE_CREDENTIALS: ${{ secrets.STORE_LOGIN }}
diff --git a/sample-project/snap/snapcraft.yaml b/sample-project/snap/snapcraft.yaml
@@ -1,5 +1,5 @@
 name: test-jamesh-publish-action
-base: core18
+base: core22
 version: '0.1'
 summary: A snap used to test the Github publish action
 description: |