-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hooks: remove dhcpcd-base #186
hooks: remove dhcpcd-base #186
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but please look at comment
# multiple dhcp clients. This change occurred recently (from time of commit) | ||
# since isc-dhcp-client will be deprecated and is currently in the process | ||
# of being demoted from packages in main universe. | ||
dpkg --purge --force-depends dhcpcd-base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nitpick: maybe a bug should be opened against cloud-init so they improve the packaging to make this optional, and then add the reference to the bug here.
Tested that should anyone need dhcdpcd, they can include it in their snap and run dhcpcd as root. The user created by the package is not required for operating. |
@Meulengracht true, but cloud-init still requires a working dhcp client to be installed
@alfonsosanchezbeato Good point, but this was already considered. The Ubuntu deb packaging requires only dhcpcd-base because dhcpcd-base is expected to be the only client in main[1] on Noble that meets the needs of cloud-init. Since isc-dhcp-client isn't expected to remain in main in 24.04, there is no point as including it as an optional dependency. Using the isc-dhcp-client is only expected on Ubuntu in the following cases 1) Ubuntu on series older than Noble and 2) Noble+ if the user manually installs isc-dhcp-client and then forces cloud-init to use it via a configuration setting. Since dhcpcd-base is included in the initramfs, ubuntu-minimal, etc[2], it is expected that on Noble and later, dhcpcd-base will always be available. [1] 2 if you include busybox, but that is currently not fully supported yet [2] various projects that made this transition off of isc-dhcp-client
|
Cloud-init now pulls in dhcpcd-base, which we are not interested in (currently). After speaking with the Server team this is due to the fact that isc-dhcp-client is becoming deprecated, and replaced by dhcpcd. However cloud-init supports multiple dhcp clients and does not in fact need dhcpcd-base currently.