Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Update cloud-init configuration #5
Conversation
| @@ -23,6 +26,3 @@ grub_dpkg: | ||
| # apt_pipelining logs warning on failed write to /etc/apt/apt.conf.d | ||
| apt_pipelining: "none" | ||
| - | ||
| -# 'apt_configure' module should not run as apt is not used. | ||
| -apt_configure_enabled: False |
ogra1
Apr 6, 2017
Contributor
are you sure dropping this will not cause errors (given there is no actual apt)
ogra1
Apr 6, 2017
Contributor
hmm, also ... is there a git add missing for the mentioned ds-identify.cfg file ?
| @@ -19,7 +19,8 @@ | ||
| /var/snap auto persistent transition none | ||
| /var/lib/bluetooth auto persistent none none | ||
| # cloud-init | ||
| -/etc/cloud auto persistent none none | ||
| +/etc/cloud auto synced none none | ||
| +/etc/cloud/cloud.cfg.d auto synced none none |
ogra1
Apr 6, 2017
Contributor
this is redundant, only /etc/cloud will be enough... else you end up with stacked bind mounts
raharper
Apr 17, 2017
Contributor
What I recall was that a writable partition with only /etc/cloud/cloud.cfg.d/XX files, didn't get copied with only the /etc/cloud sync.
Let me test again without;
raharper
Apr 17, 2017
Contributor
After some testing locally; it appears that's good enough. I used only the /etc/cloud synced mode and I can populate files to /etc/cloud and /etc/cloud/cloud.cfg.d/ in the writable partition and both show up correctly. I've updated this branch with the change.
|
On Thu, Apr 6, 2017 at 6:42 AM, Oliver Grawert ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In config/etc/cloud/cloud.cfg.d/10_snappy.cfg
<#5 (comment)>:
> @@ -23,6 +26,3 @@ grub_dpkg:
# apt_pipelining logs warning on failed write to /etc/apt/apt.conf.d
apt_pipelining: "none"
-
-# 'apt_configure' module should not run as apt is not used.
-apt_configure_enabled: False
hmm, also ... is there a git add missing for the mentioned ds-identify.cfg
file ?
ACK, sorry. Just pushed.
…
|
|
This looks fine, thank you! Please note that existing systems will not get an updated We also have a |
|
@mvo5 snapcore/core#30 has the code to drop 99-snappy-disable-network-config.cfg, i guess we need to land both together (once the stable release is out we should do a coordinated landing and test build) |
raharper commentedApr 5, 2017
configured requires cloud-init systemd generator to detect local
datasource to enable cloud-init, otherwise it will remain disabled.
enables the default configuration of cloud-init in the core image to be
merged with configuration files which are added to the writable
partition.
now skips running this module if the system it's running on is
Ubuntu Core