Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle-writable-paths: extract the writable-path handling #13

Merged
merged 1 commit into from Nov 25, 2019

Conversation

mvo5
Copy link
Contributor

@mvo5 mvo5 commented Nov 19, 2019

This PR moves the code that handle the writable-path for a core
system from the initramfs to the core20 snap. This has the benefit
that we don't have to change the initramfs if this code needs to
change. The initramfs will just call it from the core20 snap.

@mvo5 mvo5 force-pushed the handle-writable-paths branch 2 times, most recently from 5d6b86a to 2c316b6 Compare November 19, 2019 11:21
This PR moves the code that handle the writable-path for a core
system from the initramfs to the core20 snap. This has the benefit
that we don't have to change the initramfs if this code needs to
change. The initramfs will just call it from the core20 snap.
@xnox
Copy link
Contributor

xnox commented Nov 25, 2019

Not sure why we care about writing a valid fstab.
But this should do for now.
And ideally I would want to move all the mount calls to systemd-mount, such that there are units created for all of them.

@xnox xnox merged commit b7a4079 into snapcore:master Nov 25, 2019
jhenstridge pushed a commit to jhenstridge/core20 that referenced this pull request Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants