internal/xgettext, cmd/xgettext-go: add an xgettext-go command #13
Conversation
jhenstridge
force-pushed
the
xgettext-go
branch
from
b41dac4
to
2b35849
Compare
|
Hi. We would like to start using this library, including this command. Is there anything I can do to help revive this PR and get it merged? |
|
Ping again. Is there anything we can do to help you with this PR or maintenance in general? |
This is loosely based on the xgettext-go from snapd, extracting the logic into a package and extending the keyword support to handle unqualified keywords, along with plural and context keywords.
jhenstridge
force-pushed
the
xgettext-go
branch
from
2b35849
to
328f752
Compare
|
@m-horky: we're still using the package, I just didn't get round to chasing up reviews. We'd kind of hoped that the original package we'd forked from would accept some of the other changes, but that hasn't happened so I guess we should treat this as the upstream. I've updated this PR to fix up the conflicts, and will look at getting it reviewed. If you've got the time, feel free to give your own review feedback. I'll look at getting the other PRs updated. |
There was a problem hiding this comment.
Thank you.
I've went through the code and I didn't find anything that would stand out. I've tried it out on our code and it all works as expected.
I have left one note about using absolute paths; I think that may be a non-blocking comment that can be addressed later (I might try to find some time for that if needed). (I passed in absolute paths through -f {file}, my bad.)
This is based on the xgettext-go utility in the snapd tree with some refinements. The main improvements are:
Multiple keywords can be specified via
-k/--keyword. This uses the same syntax as GNU xgettext to declare plural or context keywords, so e.g.--keyword-plural=i18n.DGwould now be written as--keyword=i18n.DG:1,2. As with normal xgettext, the builtin keywords can be disabled by passing-kwithout an argument.Multiple comment tags can be registered with
-c/--add-comments. Used without a value, all comments before translatable strings are collected.We use
strconv.Unquoteto decode string constants andstrconv.Quoteto quote them for inclusion in the template. This simplifies the handling, and means we correctly handle string constants like"hello "+`world`.