repo: multi-arch build deps #1346
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 2, 2017
|
@kalikiana please resolve the conflics. |
kalikiana
force-pushed
the
multi-arch-build-deps
branch
2 times, most recently
from
680d1a9
to
bf536d8
Compare
…ulti-arch-build-deps
kalikiana
force-pushed
the
multi-arch-build-deps
branch
from
bf536d8
to
0706476
Compare
kyrofa
reviewed
Jun 22, 2017
| The following information may help to resolve the situation: | ||
|
|
||
| The following packages have unmet dependencies: | ||
| builddeps:{}{} : {} |
There was a problem hiding this comment.
I typically find that it's clearer to name these when used in a larger template like this. Otherwise changes become quite fragile.
| return build_deps | ||
|
|
||
| with tempfile.NamedTemporaryFile(suffix='.dsc') as fake_source: | ||
| depends = 'Build-Depends: {}\n'.format(', '.join(package_names)) |
There was a problem hiding this comment.
Can you explain how this has different results than using something like apt_pkg.parse_depends()?
There was a problem hiding this comment.
This seems horrifically wrong. Parsing the Debian Source Control file directly should be unnecessary, as APT already has this information...
There was a problem hiding this comment.
The code generates the .dsc file based on build-packages and calls apt-get build-dep - there's nothing to parse here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Figure out dependencies in a multi-arch compatible way using apt-get build-dep.
Follow-up on go plugin: Cross compile with CGo