jhbuild plugin: fix UnboundLocalError for chmod_path #1534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move for-loop into the same scope as the variable `chmod_path`.
come-maiz
suggested changes
Sep 6, 2017
There was a problem hiding this comment.
It would be great to have a unit test that covers this bug. We are a now running to get the next release out, and this plugin will be experimental for a few iterations. But do you have in mind how those unit tests would look like? Is that something you can do as a follow up?
Thanks @diddledan!
snapcraft/plugins/jhbuild.py
Outdated
| if not os.path.exists(filename): | ||
| continue | ||
| os.chown(filename, jhbuild_user, jhbuild_group) | ||
| for filename in glob.iglob('%s/**' % chmod_path, recursive=True): |
There was a problem hiding this comment.
now that we are here, could you please use .format instead of %?
as requested by code review from @ElOpio
lucyllewy
force-pushed
the
lp-1715507
branch
from
d322a57
to
08c080d
Compare
sergiusens
approved these changes
Sep 7, 2017
sergiusens
changed the title
|
it is all green according to the link, just not updating here. |
kalikiana
pushed a commit
to kalikiana/snapcraft
that referenced
this pull request
Sep 21, 2017
Move for-loop into the same scope as the variable `chmod_path`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move for-loop into the same scope as the variable
chmod_path.fixes: https://bugs.launchpad.net/snapcraft/+bug/1715507
./runtests.sh static?./runtests.sh unit?Failing test groups:
None of those touch the jhbuild plugin so I propose the merge anyway.