Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add lifecycle ordering tests #2163

Merged
merged 2 commits into from Jun 20, 2018

Conversation

kyrofa
Copy link
Contributor

@kyrofa kyrofa commented Jun 19, 2018

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

Also, generally refactor the lifecycle tests into their own package.

Also, generally refactor the lifecycle tests into their own package.

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
if p.name in dependent_part_names}

# Keep ordering
dependent_parts = [p for p in config.all_parts
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this rings a bell, I bet if we run blame we will see it was once a list 😛

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@codecov-io
Copy link

codecov-io commented Jun 19, 2018

Codecov Report

Merging #2163 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2163      +/-   ##
==========================================
+ Coverage   91.19%   91.21%   +0.02%     
==========================================
  Files         198      198              
  Lines       12471    12471              
  Branches     1846     1846              
==========================================
+ Hits        11373    11376       +3     
+ Misses        742      741       -1     
+ Partials      356      354       -2
Impacted Files Coverage Δ
snapcraft/internal/lifecycle/_clean.py 85.08% <100%> (ø) ⬆️
snapcraft/internal/pluginhandler/__init__.py 92.42% <0%> (+0.32%) ⬆️
snapcraft/internal/lifecycle/_runner.py 92.85% <0%> (+0.59%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44ae843...e259fdc. Read the comment docs.

@sergiusens sergiusens merged commit efebd07 into canonical:master Jun 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants