Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: add spread suite for cmake plugin #2183

Merged
merged 3 commits into from Aug 2, 2018

Conversation

kyrofa
Copy link
Contributor

@kyrofa kyrofa commented Jul 27, 2018

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

This PR resolves LP: #1783830 by moving the plugin and snapd integration tests for the CMake plugin into a Spread suite.

@kyrofa kyrofa force-pushed the feature/1783830/spread_cmake branch from 86c9b01 to 97d88e8 Compare July 30, 2018 15:18
@codecov-io
Copy link

codecov-io commented Jul 30, 2018

Codecov Report

Merging #2183 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2183   +/-   ##
=======================================
  Coverage   91.23%   91.23%           
=======================================
  Files         201      201           
  Lines       12898    12898           
  Branches     1912     1912           
=======================================
  Hits        11767    11767           
  Misses        768      768           
  Partials      363      363

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b412242...943b0b2. Read the comment docs.

Move the plugin and snapd integration tests for the CMake plugin into a
Spread suite.

LP: #1783830

Signed-off-by: Kyle Fazzari <kyrofa@ubuntu.com>
@kyrofa kyrofa force-pushed the feature/1783830/spread_cmake branch from 97d88e8 to 5ad3d32 Compare July 30, 2018 16:30
@@ -1,11 +1,12 @@
name: cmake-hello
version: 0.1
version: 1.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is missing quotes

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, fixed.

summary: test the cmake plugin
description: |
This is a basic cmake snap. It just prints a hello world.
If you want to add other functionalities to this snap, please don't.
Make a new one.
icon: icon.png
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great, we do not need icons :-)

Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great

@sergiusens sergiusens merged commit 51518db into canonical:master Aug 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants