-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve pr template and tools ignored files #2191
Improve pr template and tools ignored files #2191
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2191 +/- ##
==========================================
+ Coverage 91.19% 91.21% +0.02%
==========================================
Files 202 208 +6
Lines 12992 13160 +168
Branches 1922 1957 +35
==========================================
+ Hits 11848 12004 +156
- Misses 776 788 +12
Partials 368 368
Continue to review full report at Codecov.
|
pyproject.toml
Outdated
@@ -8,6 +8,7 @@ exclude = ''' | |||
| \.venv | |||
| _build | |||
| buck-out | |||
| __pycache__ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While you're at it, mind adding .vscode here as well? Just got bit by this yesterday!
50edd37
to
d6ca333
Compare
@kyrofa I've updated the PR ;-) |
.hg, | ||
.mypy_cache, | ||
.tox, | ||
.venv, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a questions.
is this particular to the way you set things up or is there general tooling that does this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
.mypy_cache
and.tox
are standard directories.hg
is standard directory, but this repo is a git one so this souldn't be useful (I kept it because it was already present in thepyproject.toml
).venv
is not a standard directory (but was present in thepyproject.toml
), this is anyway useful given a lot of people keep the project's virtualenv inside the repo (I personally call itvenv
instead of.venv
but given there is no standard on this naming I guess.venv
is fine)
No idea why travis is failing... is there something I can do ? |
No, it's been falling all over itself since yesterday, we'll all up a creek right now. |
./runtests.sh static
?./runtests.sh unit
?Small PR to fix the informative message displayed while creating PR and to keep coherent the ignore pattern between tools (really annoying to black refactors zillions of files because you created your virtual env with a name different from
.venv
, only to get zillions of code smells from the venv because flake8 still lint.venv
folder...)