Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve pr template and tools ignored files #2191

Conversation

touilleMan
Copy link
Contributor

@touilleMan touilleMan commented Aug 3, 2018

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • If this is a bugfix. Have you checked that there is a bug report open for the issue you are trying to fix on bug reports?
  • If this is a new feature. Have you discussed the design on the forum?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh unit?

Small PR to fix the informative message displayed while creating PR and to keep coherent the ignore pattern between tools (really annoying to black refactors zillions of files because you created your virtual env with a name different from .venv, only to get zillions of code smells from the venv because flake8 still lint .venv folder...)

@codecov-io
Copy link

codecov-io commented Aug 3, 2018

Codecov Report

Merging #2191 into master will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2191      +/-   ##
==========================================
+ Coverage   91.19%   91.21%   +0.02%     
==========================================
  Files         202      208       +6     
  Lines       12992    13160     +168     
  Branches     1922     1957      +35     
==========================================
+ Hits        11848    12004     +156     
- Misses        776      788      +12     
  Partials      368      368
Impacted Files Coverage Δ
snapcraft/cli/parts.py 82.14% <0%> (-13.51%) ⬇️
snapcraft/internal/pluginhandler/__init__.py 90.16% <0%> (-0.92%) ⬇️
snapcraft/internal/states/__init__.py 100% <0%> (ø) ⬆️
snapcraft/internal/lifecycle/__init__.py 100% <0%> (ø) ⬆️
...internal/project_loader/inspection/_latest_step.py 100% <0%> (ø)
...aft/internal/project_loader/inspection/__init__.py 100% <0%> (ø)
...nal/project_loader/inspection/_lifecycle_status.py 100% <0%> (ø)
...ft/internal/project_loader/inspection/_provides.py 94.73% <0%> (ø)
...craft/internal/project_loader/inspection/errors.py 94.44% <0%> (ø)
snapcraft/cli/inspect.py 93.75% <0%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5498d0a...5509f21. Read the comment docs.

pyproject.toml Outdated
@@ -8,6 +8,7 @@ exclude = '''
| \.venv
| _build
| buck-out
| __pycache__
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it, mind adding .vscode here as well? Just got bit by this yesterday!

@touilleMan touilleMan force-pushed the improve-PR-template-and-tools-ignored-files branch from 50edd37 to d6ca333 Compare August 5, 2018 16:55
@touilleMan
Copy link
Contributor Author

@kyrofa I've updated the PR ;-)

.hg,
.mypy_cache,
.tox,
.venv,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a questions.
is this particular to the way you set things up or is there general tooling that does this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • .mypy_cache and .tox are standard directories
  • .hg is standard directory, but this repo is a git one so this souldn't be useful (I kept it because it was already present in the pyproject.toml)
  • .venv is not a standard directory (but was present in the pyproject.toml), this is anyway useful given a lot of people keep the project's virtualenv inside the repo (I personally call it venv instead of .venv but given there is no standard on this naming I guess .venv is fine)

@touilleMan
Copy link
Contributor Author

No idea why travis is failing... is there something I can do ?

@kyrofa
Copy link
Contributor

kyrofa commented Aug 11, 2018

No idea why travis is failing... is there something I can do ?

No, it's been falling all over itself since yesterday, we'll all up a creek right now.

@sergiusens sergiusens merged commit c1b0eaf into canonical:master Aug 13, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants