tests: add spread suite for plainbox plugin #2317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
reminder, amend the commit message |
sergiocazzolato
suggested changes
Oct 3, 2018
| execute: | | ||
| cd "$SNAP_DIR" | ||
| snapcraft | ||
| sudo snap install checkbox-simple_*.snap --dangerous |
There was a problem hiding this comment.
sudo is not needed here
sergiusens
force-pushed
the
spread-plainbox
branch
from
88452e0
to
21a5487
Compare
Codecov Report
@@ Coverage Diff @@
## master #2317 +/- ##
=========================================
Coverage ? 90.31%
=========================================
Files ? 213
Lines ? 13489
Branches ? 2008
=========================================
Hits ? 12183
Misses ? 894
Partials ? 412Continue to review full report at Codecov.
|
sergiusens
force-pushed
the
spread-plainbox
branch
2 times, most recently
from
1da7750
to
f52110e
Compare
Move the plugin and snapd integration tests for the plainbox plugin into a Spread suite. Also pin the checkbox-ng package in the tests checkbox snap. Also removed a test that looks more like a plainbox tests and not a snapcraft one. LP: #1783839 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
force-pushed
the
spread-plainbox
branch
from
f52110e
to
1fbfb6d
Compare
sergiocazzolato
approved these changes
Oct 4, 2018
sergiusens
added a commit
to sergiusens/snapcraft
that referenced
this pull request
Oct 4, 2018
Move the plugin and snapd integration tests for the plainbox plugin into a Spread suite. Also pin the checkbox-ng package in the tests checkbox snap. Also removed a test that looks more like a plainbox tests and not a snapcraft one. LP: #1783839 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
sergiusens
added a commit
that referenced
this pull request
Oct 4, 2018
Move the plugin and snapd integration tests for the plainbox plugin into a Spread suite. Also pin the checkbox-ng package in the tests checkbox snap. Also removed a test that looks more like a plainbox tests and not a snapcraft one. LP: #1783839 Signed-off-by: Sergio Schvezov <sergio.schvezov@canonical.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the plugin and snapd integration tests for the CMake plugin into a
Spread suite.
Also pin the checkbox-ng package in the tests checkbox snap.
LP: #1783839
Signed-off-by: Sergio Schvezov sergio.schvezov@canonical.com
./runtests.sh static?./runtests.sh tests/unit?