Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repo: handle deb package fetch error #2513

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

cmatsuoka
Copy link
Contributor

End gracefully instead of crashing if a deb package can't be
fetched.

Fixes SNAPCRAFT-JE
Fixes SNAPCRAFT-JF

Signed-off-by: Claudio Matsuoka claudio.matsuoka@canonical.com

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

@codecov-io
Copy link

codecov-io commented Mar 25, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@46e3d17). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #2513   +/-   ##
=========================================
  Coverage          ?   89.92%           
=========================================
  Files             ?      198           
  Lines             ?    13382           
  Branches          ?     2025           
=========================================
  Hits              ?    12034           
  Misses            ?      923           
  Partials          ?      425
Impacted Files Coverage Δ
snapcraft/internal/repo/_deb.py 74.22% <100%> (ø)
snapcraft/internal/repo/errors.py 83.13% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46e3d17...957b2a7. Read the comment docs.

Copy link
Collaborator

@sergiusens sergiusens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good, mind updating the copyright years though?

End gracefully instead of crashing if a deb package can't be
fetched.

Fixes SNAPCRAFT-JE
Fixes SNAPCRAFT-JF

Signed-off-by: Claudio Matsuoka <claudio.matsuoka@canonical.com>
@cmatsuoka
Copy link
Contributor Author

Copyright notice dates updated. Good catch, it's quite easy to forget to update those.

@cmatsuoka cmatsuoka closed this Mar 25, 2019
@cmatsuoka cmatsuoka reopened this Mar 25, 2019
@sergiusens sergiusens merged commit 3e8bcc9 into canonical:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants