elf: extract defined symbol versions #3408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3408 +/- ##
==========================================
- Coverage 90.77% 90.75% -0.02%
==========================================
Files 256 256
Lines 18186 18194 +8
==========================================
+ Hits 16508 16512 +4
- Misses 1678 1682 +4
Continue to review full report at Codecov.
|
sergiusens
approved these changes
Jan 11, 2021
abitrolly
pushed a commit
to abitrolly/snapcraft
that referenced
this pull request
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
./runtests.sh static?./runtests.sh tests/unit?I think it would be useful for Snapcraft to warn if a snap was missing libraries, or including duplicate libraries provided by the base snap or a content interface snap.
The current
ElfFileclass contains most of this information, in the form of the list of needed libraries together with the required symbol versions. What is missing is a list of symbol versions defined by the library. This PR adds that information to the class.