Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions/kde-neon: declare non-experimental for core20 #3598

Merged
merged 2 commits into from Jan 10, 2022

Conversation

ppd
Copy link
Contributor

@ppd ppd commented Nov 24, 2021

From the removed TODO comment:
"remove experimental once sdk is on stable"

As the SDK snap kde-frameworks-5-qt-5-15-3-core20-sdk has
a stable revision now, the experimental flag can
be removed, and the build snap can be pulled from the
stable channel.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run ./runtests.sh static?
  • Have you successfully run ./runtests.sh tests/unit?

Includes #3596, but I can remove that if necessary and rebase later.
This is also significant because launchpad build jobs cannot be configured to enable experimental extensions at the moment, which prevents many snaps from using this extension.

@ppd ppd force-pushed the kde-neon-not-experimental branch 4 times, most recently from c00f376 to c93e23e Compare November 24, 2021 11:15
From the removed TODO comment:
"remove experimental once sdk is on stable"

As the SDK snap kde-frameworks-5-qt-5-15-3-core20-sdk has
a stable revision now, the experimental flag can
be removed, and the build snap can be pulled from the
stable channel.
@sergiusens sergiusens merged commit bb816be into canonical:main Jan 10, 2022
@ppd ppd deleted the kde-neon-not-experimental branch January 10, 2022 23:03
mr-cal pushed a commit to mr-cal/snapcraft that referenced this pull request Apr 28, 2022
extensions/kde-neon: declare non-experimental for core20
mr-cal pushed a commit to mr-cal/snapcraft that referenced this pull request Apr 28, 2022
extensions/kde-neon: declare non-experimental for core20
mr-cal pushed a commit to mr-cal/snapcraft that referenced this pull request Apr 29, 2022
extensions/kde-neon: declare non-experimental for core20
mr-cal pushed a commit to mr-cal/snapcraft that referenced this pull request Apr 29, 2022
extensions/kde-neon: declare non-experimental for core20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants