Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions: replace execs with source #3869

Conversation

sergio-costas
Copy link
Contributor

@sergio-costas sergio-costas commented Aug 11, 2022

Using source it is possible to simplify the chain, reduce memory usage and make execution faster.

This MR emulates "exec $@" using "source", thus avoiding to create a new process and launching a new shell each time a shell script must be executed from another shell script.

  • Have you followed the guidelines for contributing?
  • Have you signed the CLA?
  • Have you successfully run make lint?
  • Have you successfully run pytest tests/unit?

DT-504

@sergio-costas sergio-costas force-pushed the DT-504-use-source-in-snapcraft-launch-scripts branch 2 times, most recently from 9dfeebc to bd22b75 Compare August 11, 2022 16:50
Using source it is possible to simplify the chain, reduce memory
usage and make execution faster.
@sergio-costas sergio-costas force-pushed the DT-504-use-source-in-snapcraft-launch-scripts branch from bd22b75 to 16e7892 Compare August 11, 2022 17:04
@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2022

Codecov Report

Merging #3869 (bd22b75) into main (ed6f871) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head bd22b75 differs from pull request most recent head 16e7892. Consider uploading reports for the commit 16e7892 to get more accurate results

@@           Coverage Diff           @@
##             main    #3869   +/-   ##
=======================================
  Coverage   88.34%   88.35%           
=======================================
  Files          77       77           
  Lines        4666     4670    +4     
=======================================
+ Hits         4122     4126    +4     
  Misses        544      544           
Impacted Files Coverage Δ
snapcraft/commands/names.py 89.83% <0.00%> (ø)
snapcraft/store/client.py 93.18% <0.00%> (+0.21%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sergiusens sergiusens changed the title DT-504 Remove unneeded execs extensions: replace execs with source Aug 12, 2022
@sergiusens sergiusens merged commit 673c9d0 into canonical:main Aug 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants