providers: move mount logic to lifecycle.py #3930
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mr-cal
force-pushed
the
craft-providers-mount
branch
from
218f114
to
387846e
Compare
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
mr-cal
force-pushed
the
craft-providers-mount
branch
from
387846e
to
4b8f84a
Compare
facundobatista
suggested changes
Oct 4, 2022
Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>
Codecov Report
@@ Coverage Diff @@
## main #3930 +/- ##
==========================================
+ Coverage 89.88% 89.91% +0.03%
==========================================
Files 61 61
Lines 4170 4165 -5
==========================================
- Hits 3748 3745 -3
+ Misses 422 420 -2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make lint?pytest tests/unit?Moves the snapcraft-specific calls for mounting directories to
parts/lifecycle.py.Similar to canonical/rockcraft#82
(CRAFT-1397)