New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: add unit test for `capture_logs_from_instance()` #3937

Merged

mr-cal merged 1 commit into canonical:main from mr-cal:craft-providers-capture-logs-unit-tests

Oct 5, 2022

Collaborator

mr-cal commented Oct 5, 2022

Have you followed the guidelines for contributing?
Have you signed the CLA?
Have you successfully run make lint?
Have you successfully run pytest tests/unit?

I forgot to add unit tests for #3935.

Tests were pulled from rockcraft

(CRAFT-1307)


          tests: add unit test for capture_logs_from_instance()

Signed-off-by: Callahan Kovacs <callahan.kovacs@canonical.com>

sergiusens approved these changes

View reviewed changes

mr-cal enabled auto-merge (squash)

October 5, 2022 18:26

mr-cal merged commit a5d2d92 into canonical:main

mr-cal deleted the craft-providers-capture-logs-unit-tests branch

October 5, 2022 19:18

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment