allow dual build of qt5 and qt6 #147
Conversation
It's what we are using in Discover now.
|
This is a bad idea and in general probably unnecessary, since the only consumer is Plasma Discover (which is now Qt6 only). |
|
The value in this is we can ship these updated versions to older releases which use the old version of Qt5 version of Plasma discover. If we drop Qt5 support completely then we'd have to start a branch. |
|
But do we need to be able to build both at once? And do they need to be parallel installable? I don't think so. |
|
Right, I don't think there's any need to be parallel installed. |
|
Hi, @carlosdem Can some ETA be given on this, considering, we'll be using this library to upgrade the discover backend. Please let me know, if I can help somehow. |
|
This makes a lot of unnecessary changes, including changing the names of the pkgconfig and cmake files, which breaks building things. |
I was going to work on the Snap backend of discover in this upcoming GSOC under the mentorship of @ScarlettGatelyMoore, so, if possible, can we also add this migration under that umbrella? We can pick up things where it's currently now. Considering this PR almost builds perfectly, because I did built it from source today. Can a plan be made to add this under GSOC, so, that we can work. All of our work will depend on this. So, this port is really needed. |
|
I'll finish it tomorrow (AEST time) and make it single build qt5 or qt6 only as requested. |
Thanks a lot! |
make qt bindings default to qt6 and only build one qt major version at a time
@soumyaDghosh sorry life got in the way a bit. new version is up. |
|
Thanks @carlosdem! I've updated the CI so it now builds on the older releases. |
this work is based on apol's pull request #143. it tries to support both qt5 and qt6 builds through some meson trickery inspired by the latest libappstream release.