tests: skip overlord tests on riscv64 due to timeouts. #10736
Conversation
stolowski
added
Simple 😃
overlord/overlord_test.go
Outdated
| @@ -80,6 +81,11 @@ func fakePruneTicker() (w *ticker, restore func()) { | |||
| } | |||
|
|
|||
| func (ovs *overlordSuite) SetUpTest(c *C) { | |||
| // temporary: skip due to timeouts on riscv64 | |||
| if runtime.GOARCH == "riscv64" { | |||
There was a problem hiding this comment.
hm maybe we could set an env flag to skip those tests during the build? I sometimes saw those tests fail to OBS too (probably running in some low-resource VMs) and would happily reuse the flag if possible.
There was a problem hiding this comment.
How about if runtime.GOARCH == "riscv64" || os.Getenv("SKIP_SLOW_TESTS") != "" { ?
There was a problem hiding this comment.
SNAPD_SKIP_SLOW_TESTS maybe?
Codecov Report
@@ Coverage Diff @@
## master #10736 +/- ##
==========================================
+ Coverage 78.37% 78.38% +0.01%
==========================================
Files 887 887
Lines 99755 99751 -4
==========================================
+ Hits 78182 78189 +7
+ Misses 16670 16661 -9
+ Partials 4903 4901 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Temporary workaround to unblock riscv64 builds.