Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

interfaces/system-observe: allow clients to enumerate DBus connection names #3928

Merged
merged 4 commits into from
Sep 22, 2017

Conversation

jdstrand
Copy link

This came up within the context of https://forum.snapcraft.io/t/ubuntu-core-dbus-interface-question/2138/3. While one could argue that this access should be in a different interface, I feel it makes sense to add to the existing system-observe, since this is similar to ps aux output (which system-observe allows), but for DBus.

@jdstrand
Copy link
Author

Note the CI test failures were unrelated to this PR, so I restarted them hoping they were transient.

Copy link
Contributor

@zyga zyga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

Codecov Report

Merging #3928 into master will increase coverage by 0.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #3928     +/-   ##
=========================================
+ Coverage   75.92%   76.02%   +0.1%     
=========================================
  Files         418      420      +2     
  Lines       36295    36436    +141     
=========================================
+ Hits        27556    27701    +145     
+ Misses       6806     6802      -4     
  Partials     1933     1933
Impacted Files Coverage Δ
interfaces/builtin/system_observe.go 100% <ø> (ø) ⬆️
interfaces/core.go 98.97% <0%> (-1.03%) ⬇️
httputil/transport17.go 100% <0%> (ø)
httputil/redirect18.go 100% <0%> (ø)
dirs/dirs.go 98.29% <0%> (+0.21%) ⬆️
interfaces/repo.go 98.08% <0%> (+0.27%) ⬆️
cmd/snap/cmd_aliases.go 95% <0%> (+1.66%) ⬆️
interfaces/apparmor/backend.go 77.04% <0%> (+4.99%) ⬆️
httputil/useragent.go 85% <0%> (+7.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6b250c2...0d17bdf. Read the comment docs.

@mvo5 mvo5 merged commit 4ba8059 into canonical:master Sep 22, 2017
@jdstrand
Copy link
Author

Thanks!

@jdstrand jdstrand deleted the add-dbus-listnames-to-system-observe branch September 22, 2017 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants