Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

many: use the new install/refresh /v2/snaps/refresh store API (2.32) #5002

Merged

Conversation

pedronis
Copy link
Collaborator

@pedronis pedronis commented Apr 6, 2018

This is the backport for 2.32.x of the whole support and switch of snapd to use the new /v2/snaps/refresh store API to handle both install and refreshes.

@pedronis pedronis added the ⚠ Critical High-priority stuff (e.g. to fix master) label Apr 6, 2018
@pedronis pedronis added this to the 2.32 milestone Apr 6, 2018
@pedronis pedronis changed the title many: use the new install/refresh API by switching snapstate to use store.SnapAction. many: use the new install/refresh /v2/snaps/refresh store API Apr 6, 2018
@pedronis pedronis requested a review from mvo5 April 6, 2018 12:26
@codecov-io
Copy link

Codecov Report

Merging #5002 into release/2.32 will increase coverage by 0.05%.
The diff coverage is 84.02%.

Impacted file tree graph

@@               Coverage Diff                @@
##           release/2.32    #5002      +/-   ##
================================================
+ Coverage         78.62%   78.68%   +0.05%     
================================================
  Files               472      473       +1     
  Lines             34618    34988     +370     
================================================
+ Hits              27219    27529     +310     
- Misses             5190     5225      +35     
- Partials           2209     2234      +25
Impacted Files Coverage Δ
cmd/snap/cmd_snap_op.go 67.36% <100%> (ø) ⬆️
overlord/snapstate/handlers.go 71.74% <100%> (ø) ⬆️
store/errors.go 71.18% <100%> (+71.18%) ⬆️
overlord/snapstate/snapmgr.go 86.36% <100%> (+0.28%) ⬆️
daemon/api.go 75.53% <100%> (ø) ⬆️
tests/lib/fakestore/store/store.go 64.46% <60%> (-0.05%) ⬇️
overlord/snapstate/snapstate.go 81.49% <66.66%> (ø) ⬆️
store/store.go 82.25% <84.53%> (+0.5%) ⬆️
overlord/snapstate/storehelpers.go 80.76% <84.55%> (-1.74%) ⬇️
store/details_v2.go 97.05% <97.05%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4c2b0d...77df8a5. Read the comment docs.

@pedronis
Copy link
Collaborator Author

pedronis commented Apr 6, 2018

marked as blocked until 2.32.3 has reached stable

@pedronis pedronis changed the title many: use the new install/refresh /v2/snaps/refresh store API many: use the new install/refresh /v2/snaps/refresh store API (2.32) Apr 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⚠ Critical High-priority stuff (e.g. to fix master)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants