snap-confine: fix incorrect use "src" var in mount-support.c #6336
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We got a bugreport from fedora that gcc-9 fails to build with
current snapd:
```
snap-confine/mount-support.c: In function 'sc_bootstrap_mount_namespace':
snap-confine/mount-support.c:403:4: error: '%s' directive argument is null [-Werror=format-overflow=]
403 | die("cannot use result from readlink: %s", src);
| ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:2507: snap-confine/snap_confine_debug-mount-support.o] Error 1
make[1]: *** Waiting for unfinished jobs....
```
This PR fixes this issue.
bboozzoo
approved these changes
Jan 9, 2019
mvo5
added a commit
to mvo5/snappy
that referenced
this pull request
Jan 31, 2019
snap-confine: fix incorrect use "src" var in mount-support.c
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We got a bugreport from fedora that gcc-9 fails to build with current snapd:
This PR fixes this issue. Thanks to Jeff Law for reporting the issue!