cmd/snap, api, snapstate: implement "snap remove --purge" #6870
Conversation
overlord/snapstate/snapstate.go
Outdated
| @@ -66,6 +66,10 @@ const ( | |||
|
|
|||
| var ErrNothingToDo = errors.New("nothing to do") | |||
|
|
|||
| type RemoveFlags struct { | |||
| Purge bool | |||
There was a problem hiding this comment.
Can you please document this field. Could be as simple as refrain from creating data snapshot on snap remove
There was a problem hiding this comment.
mmh, should this go into flags.go instead? it's very far from Remove here anyway? cc @chipaca
There was a problem hiding this comment.
actually, yes, good catch. This is what Flags is for.
cmd/snap/cmd_snap_op.go
Outdated
| @@ -991,6 +992,8 @@ func init() { | |||
| waitDescs.also(map[string]string{ | |||
| // TRANSLATORS: This should not start with a lowercase letter. | |||
| "revision": i18n.G("Remove only the given revision"), | |||
| // TRANSLATORS: This should not start with a lowercase letter. | |||
| "purge": i18n.G("Remove the snap without creating snapshot data"), | |||
There was a problem hiding this comment.
"Remove the snap without creating a snapshot of the data" ? cc @chipaca or s/of the/of its/
There was a problem hiding this comment.
👍 to @pedronis' suggestion, Remove the snap without creating a snapshot of its data (although it's only a small thing).
There was a problem hiding this comment.
Agreed either of those reads better, although @degville would know more.
One thing though, would be nice if we used the save verb, as that's what we use for snapshots (ie something like Remove the snap without first saving a snapshot of its data)
There was a problem hiding this comment.
(but the negation there feels weird to me)
There was a problem hiding this comment.
How about "Remove the snap without saving a snapshot of its data"? (note no "first")
There was a problem hiding this comment.
(but the negation there feels weird to me)
Yeah, it does a little. It's a little cleaner without first:
Remove the snap without saving a snapshot of its data
overlord/snapstate/snapstate.go
Outdated
| @@ -66,6 +66,10 @@ const ( | |||
|
|
|||
| var ErrNothingToDo = errors.New("nothing to do") | |||
|
|
|||
| type RemoveFlags struct { | |||
| Purge bool | |||
There was a problem hiding this comment.
mmh, should this go into flags.go instead? it's very far from Remove here anyway? cc @chipaca
|
Supported in snapd-glib 1.50. REST API updated. |
Implementation of
snap remove --purge ...as proposed here: https://forum.snapcraft.io/t/automatic-snapshots-snap-remove-purge-proposal/11294/2 and discussed briefly a while ago.The idea is to allow disabling automatic snapshot for given remove, without having to disable it globally for all snaps. This is useful for removing fat snaps (such as multipass) if the user doesn't want the backup.