Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/snap-bootstrap/initramfs-mounts: also copy systemd clock + netplan files #8795

Conversation

anonymouse64
Copy link
Contributor

The netplan files are needed if a user configured their device to only use WiFi for example.

The systemd clock file is as described in https://bugs.launchpad.net/snapd/+bug/1878422.

This will need to propagate through ubuntu-core-initramfs and then the kernel snap before it ends up usable for any devices. Furthermore, since recover mode will use the kernel snap from the recovery system, this fix will only apply for devices with a recovery system that was built with a kernel snap that contains this fix in the initramfs.

…n files

The netplan files are needed if a user configured their device to only
use WiFi for example.

The systemd clock file is as described in
https://bugs.launchpad.net/snapd/+bug/1878422.

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
Copy link
Contributor

@mvo5 mvo5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@bboozzoo bboozzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM wIth @mvo5's patch

@pedronis pedronis self-requested a review June 3, 2020 12:32
Copy link
Collaborator

@pedronis pedronis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the TODO could mention ubuntu-save

cmd/snap-bootstrap/cmd_initramfs_mounts.go Show resolved Hide resolved
…etwork conf

Thanks to @pedronis for the suggestion.

Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
@mvo5 mvo5 merged commit e53cf50 into canonical:master Jun 4, 2020
@anonymouse64 anonymouse64 deleted the bugfix/uc20-copy-network-time-files-to-recover-mode branch June 4, 2020 13:56
anonymouse64 added a commit that referenced this pull request Jul 24, 2020
…-part1

cmd/snap-bootstrap,seed: backport of uc20 PR's (2.45)

This has the following PR's :

- #8890
- #8652
- #8795
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants