-
Notifications
You must be signed in to change notification settings - Fork 573
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/snap-bootstrap/initramfs-mounts: also copy systemd clock + netplan files #8795
cmd/snap-bootstrap/initramfs-mounts: also copy systemd clock + netplan files #8795
Conversation
…n files The netplan files are needed if a user configured their device to only use WiFi for example. The systemd clock file is as described in https://bugs.launchpad.net/snapd/+bug/1878422. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM wIth @mvo5's patch
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, the TODO could mention ubuntu-save
…etwork conf Thanks to @pedronis for the suggestion. Signed-off-by: Ian Johnson <ian.johnson@canonical.com>
The netplan files are needed if a user configured their device to only use WiFi for example.
The systemd clock file is as described in https://bugs.launchpad.net/snapd/+bug/1878422.
This will need to propagate through ubuntu-core-initramfs and then the kernel snap before it ends up usable for any devices. Furthermore, since recover mode will use the kernel snap from the recovery system, this fix will only apply for devices with a recovery system that was built with a kernel snap that contains this fix in the initramfs.